Skip to content

Feature/fix categories parsing#11

Open
AFAde wants to merge 3 commits into
extent-framework:masterfrom
AFAde:feature/fix-categories-parsing
Open

Feature/fix categories parsing#11
AFAde wants to merge 3 commits into
extent-framework:masterfrom
AFAde:feature/fix-categories-parsing

Conversation

@AFAde

@AFAde AFAde commented Mar 18, 2019

Copy link
Copy Markdown

No description provided.

@anshooarora

Copy link
Copy Markdown
Member

@AFAde

Which NUnit version contains this element?

@dsparkplug

Copy link
Copy Markdown
Contributor

Categories are output as property name-value pairs as of NUnit 3. e.g. <property name="Category" value="SuperFancyCategoryName" />

See: https://nunit.org/files/testresult_30.txt

Probably should change this add support for the version 3 XML schema rather than overwriting support for version 2

@AFAde

AFAde commented Mar 25, 2019

Copy link
Copy Markdown
Author

Categories are output as property name-value pairs as of NUnit 3. e.g. <property name="Category" value="SuperFancyCategoryName" />

See: https://nunit.org/files/testresult_30.txt

Probably should change this add support for the version 3 XML schema rather than overwriting support for version 2

Yes, that's right, that's how categories are handled in the version 3. Having a new dedicated parser for version 3 is definitely a good idea.

@dsparkplug

Copy link
Copy Markdown
Contributor

Having a new dedicated parser for version 3 is definitely a good idea.

Maybe. But for now, I would suggest editing the pull request to include both the if (parser(elem, "categories").Any()) and if (parser(elem, "properties").Any()) sections of the code so that this parser works with results from all versions of NUnit.

@AFAde

AFAde commented Mar 25, 2019

Copy link
Copy Markdown
Author

Having a new dedicated parser for version 3 is definitely a good idea.

Maybe. But for now, I would suggest editing the pull request to include both the if (parser(elem, "categories").Any()) and if (parser(elem, "properties").Any()) sections of the code so that this parser works with results from all versions of NUnit.

Speaking in terms of clean code, I am not sure whether that's a good solution; it will fix the issue but it will introduce a kind of code smell, if you ask me. If you want to keep it simple, I would rather give up the compatibility with NUnit 2, which is no longer maintained. But I leave the final decision to you.

@esrahofstede

Copy link
Copy Markdown

Are there any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants